-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ISSM model and supporting packages #42
Conversation
This is a Fortran optimisation routine, one of the prerequisites for ISSM.
This is great @angus-g, thanks. I agree it would be good for the package to be called Do you imagine that you'll make a PR for I'll try and give the build a burl tomorrow. |
I'll have to verify the license for m1qn3, but I could do that, yes. |
Hi @aidanheerdegen , @angus-g is coming over to the office on Tuesday afternoon to walk-through the PR. |
We did an in-person review today. TODO: Licenses, header comment in patch file, do |
This version of intel-oneapi-mkl overrides the component_prefix property to work with the non-standard paths used on Gadi.
This is a fairly simple configuration of ISSM, but it demonstrates building with Intel compilers and MKL to bring in the PETSc dependency.
e856880
to
d618d7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: do from spack.package import install, mkdirp
instead of from spack.package import *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks again @angus-g
As mentioned in #20, here is the ISSM package which pulls in PETSc and builds using Intel compilers and MKL on Gadi. The
packages.yaml
may need to be modified for site configurations to specify thatintel-oneapi-mkl
uses the+cluster
variant in order to include ScaLAPACK and BLACS.It's also possible that
intel-oneapi-mkl
can be renamed to something more NCI-specific, like the existingnci-openmpi
package.